xEventGroupSetBitsFromISR Without configUSE_TRACE_FACILITY

I was attempting to call xEventGroupSetBitsFromISR in an embedded application with out trace capability. This function is commented out if trace facility is disabled. It seems like the trace function call inside the function could just be disabled if tracing isn’t supported. Would I be OK to just use this by modifying around the trace requirement? Or is there something else I might not be aware of? event_groups.c Lines 691-704: /#if (** ( configUSETRACEFACILITY == 1 ) **&& ( INCLUDExTimerPendFunctionCall == 1 ) && ( configUSETIMERS == 1 ) )
BaseType_t xEventGroupSetBitsFromISR( EventGroupHandle_t xEventGroup, const EventBits_t uxBitsToSet, BaseType_t *pxHigherPriorityTaskWoken )
{
BaseType_t xReturn;

    traceEVENT_GROUP_SET_BITS_FROM_ISR( xEventGroup, uxBitsToSet );
    xReturn = xTimerPendFunctionCallFromISR( vEventGroupSetBitsCallback, ( void * ) xEventGroup, ( uint32_t ) uxBitsToSet, pxHigherPriorityTaskWoken );

    return xReturn;
}
/#endif

xEventGroupSetBitsFromISR Without configUSE_TRACE_FACILITY

Looking at this now I have to say I don’t know why the test against configUSETRACEFACILITY is there. Looks like it could just be a mistake but not sure without trying without it.

xEventGroupSetBitsFromISR Without configUSE_TRACE_FACILITY

I have partially resolved this issue. Everything builds correctly when buildling in the target with trace turned off. However I was cross-compiling in Windows and had trace turned on, and that was causing the issues above. I have turned trace off for both the Windows build and the embedded build and I’m not seeing any build problems.

xEventGroupSetBitsFromISR Without configUSE_TRACE_FACILITY

What I found was that if trace is turned off, the header file redefines the xEventGroupSetBitsFromISR to just call xTimerPendFunctionCallFromISR with an additional needed function callback argument. So if trace is turned off, it really doesn’t expect that function to need to be compiled in. But for some reason when building it in Windows with trace turned on, it was still needing a xEventGroupSetBitsFromISR function implementation and wasn’t able to find it, which brought me to the above conditional compile checking. /#if( configUSETRACEFACILITY == 1 ) BaseTypet xEventGroupSetBitsFromISR( EventGroupHandlet xEventGroup, const EventBitst uxBitsToSet, BaseTypet *pxHigherPriorityTaskWoken ) PRIVILEGED_FUNCTION; /#else #define xEventGroupSetBitsFromISR( xEventGroup, uxBitsToSet, pxHigherPriorityTaskWoken ) xTimerPendFunctionCallFromISR( vEventGroupSetBitsCallback, ( void * ) xEventGroup, ( uint32_t ) uxBitsToSet, pxHigherPriorityTaskWoken ) /#endif